You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just wanted to check the coverage of the console module but it seems like it is missing. I am not sure if this is an issue on our side or on module side. I did not yet look into it.
Activity
BridgeAR commentedon May 28, 2018
@nodejs/build @bcoe PTAL
bcoe commentedon May 28, 2018
@BridgeAR I'm happy to take a look at why we're not seeing coverage for the console module.
maclover7 commentedon May 28, 2018
@BridgeAR @bcoe This CI job may be helpful, runs coverage everyday: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage/
bcoe commentedon May 30, 2018
@BridgeAR I've hunted things down to here and have a workaround we can apply:
babel/babel#8075
I'm going to see about getting things fixed upstream first.
build: fail on instrumentation errors
build: fail on instrumentation errors
bcoe commentedon Jun 25, 2018
@BridgeAR I think this issue should be fixed now, with some upstream changes to nyc; mind checking.
build: fail on instrumentation errors
bcoe commentedon Jul 3, 2018
@BridgeAR https://coverage.nodejs.org/coverage-f85962fe4d3afa55/root/console.js.html 👈 object to me closing this, things are looking good.
BridgeAR commentedon Jul 23, 2018
@bcoe thanks a lot for fixing this!