You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
http/2 compat request object can emit 'error' while http/1 request never emits errors. This can cause problems with servers crashing due with uncaught exception in code that assumes the http/1 behavior.
That particular emit('error', ...) is largely defensively coded and should not ever actually happen. Do you have a test case that demonstrates that it is a problem in practice?
Activity
mscdex commentedon May 11, 2018
http.ClientRequestinstances can emit errors, unless you meanhttp.IncomingMessage?ronag commentedon May 11, 2018
I meant
http.IncomingMessageronag commentedon Oct 25, 2018
@mscdex ping?
jasnell commentedon Oct 25, 2018
@ronag ... do you have a test case to reproduce?
Sorry this fell through the cracks because I was watching labels and this one didn't end up getting labeled for some reason...
/cc @nodejs/http2
ronag commentedon Oct 25, 2018
@jasnell:
Http2ServerRequesthas anemit('error', ...linejasnell commentedon Oct 25, 2018
That particular
emit('error', ...)is largely defensively coded and should not ever actually happen. Do you have a test case that demonstrates that it is a problem in practice?ronag commentedon Oct 25, 2018
No
Shouldn't it be an assertion in that case?
http2: replace unreachable error with assertion
Trott commentedon Nov 17, 2018
#24407
http2: replace unreachable error with assertion
http2: replace unreachable error with assertion
http2: replace unreachable error with assertion
http2: replace unreachable error with assertion
http2: replace unreachable error with assertion
http2: replace unreachable error with assertion