Repository navigation
stream: simplify checks for highWaterMark #19893
Description
- Version: master
- Platform: all
- Subsystem: stream
In lib/_streams_readable.js, we have a block of code like this:
(state.length < state.highWaterMark ||
state.length === 0);Because state.highWaterMark could be < 0 or null or undefined or really any object in Node < 10. However, we landed #18098 and so now we can simplify all those checks to be state.length <= state.highWaterMark.
Activity
dicearr commentedon Apr 9, 2018
So line lib/_streams_readable.js#314 and line lib/_streams_readable.js#437 needs to be replaced. Removing
state.length === 0and replacing<with<=. Am I right?sagirk commentedon Apr 9, 2018
@mcollina If no one is already working on this, I would like to volunteer. First-time node contributor.
vishal7201 commentedon Apr 10, 2018
@sagirk I have started working on the issue
bakpatrycja commentedon May 28, 2018
i also have started to work on it
stream: inline needMoreData function
kodemill commentedon May 29, 2018
@mcollina @vishal7201 I made some progress on this, since it looked like it was orphaned.
@RoGalinka sorry, I just missed your comment.
stream: inline needMoreData function
stream: inline needMoreData function