Repository navigation
lib: bootstrap should not have RegExp side effects #18930
Description
$ ./out/Release/node -p 'RegExp.$_' | head -10
{ 'target_defaults': { 'cflags': [],
'default_configuration': 'Release',
'defines': [],
'include_dirs': [],
'libraries': []},
'variables': { 'asan': 0,
'coverage': 'false',
'debug_http2': 'false',
'debug_nghttp2': 'false',
'force_dynamic_crt': 0,
(Due to fixing up config.gypi in setupConfig() in lib/internal/process.js.)
Activity
bootstrap_node: remove side effects on RegExp
gireeshpunathil commentedon Mar 29, 2018
@bnoordhuis - close-able as #19140 has landed?
bnoordhuis commentedon Mar 29, 2018
Yep, closing.
tools,bootstrap: preprocess gypi files to json