Skip to content

src: get rid of ClearWrap() #18897

Closed
Closed
src: get rid of ClearWrap()#18897
Assignees
addaleax
Labels
c++Issues and PRs that require attention from people who are familiar with C++.

Description

@bnoordhuis
bnoordhuis
opened on Feb 21, 2018

Continuing from #18656.

Commit 6bdc18c removes an erroneous ClearWrap() call that I think is indicative of a bigger problem.

Some persistent objects are sometimes destroyed by the garbage collector, sometimes by explicit action (e.g. closing of a handle), and that can leave the object in an inconsistent state.

My hunch is that most ClearWrap() calls can simply be removed.

Activity

  1. bnoordhuis
    added
    c++Issues and PRs that require attention from people who are familiar with C++.
    on Feb 21, 2018
  2. apapirovski
    added
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    on Apr 12, 2018

  3. jrasanen commented on Apr 15, 2018

    @jrasanen
    jrasanen
    on Apr 15, 2018

    @bnoordhuis So most ClearWrap functions should be removed? Which places do you think it could be left to exist?

  4. addaleax
    removed
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    on May 1, 2018
  5. addaleax
    added a commit that references this issue on May 1, 2018

    src: refactor `BaseObject` internal field management

    39d73c7
  6. addaleax
    self-assigned this
    on May 1, 2018
  7. addaleax
    closed this as completedin a9b0d82on May 3, 2018
  8. addaleax
    added a commit that references this issue on May 3, 2018

    src: refactor `BaseObject` internal field management

    bd20110
  9. MylesBorins
    added 4 commits that reference this issue on May 4, 2018

    src: access `ContextifyContext*` more directly in property cbs

    fd67e9e

    src: refactor `BaseObject` internal field management

    98a39e3

    src: access `ContextifyContext*` more directly in property cbs

    c21a52f

    src: refactor `BaseObject` internal field management

    f5d4253

  10. 5 remaining items

  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    src: access `ContextifyContext*` more directly in property cbs

    a9b0d82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions