Repository navigation
http2: refactoring heads up #16624
Description
@mcollina @addaleax @apapirovski @sebdeckers @nodejs/http2 ... just a general heads up... I'm in the process of a sizable internal refactoring of the http2 C/C++ internals. It's a combination of long standing clean up, a number of necessary performance optimizations to reduce the number of memcpy's, and a cleanup of some of the internal buffering code. The internals are going to look quite a bit different by the time I'm done on this. It will likely take me a day or two.
Activity
addaleax commentedon Oct 30, 2017
btw, #16461 is pretty much good to go, I’ll kick off CI in a bit & land if it comes back green, so it might be helpful to work off that :)
jasnell commentedon Oct 30, 2017
Dang... forgot about that one and I'm already a fair bit down the road. Ok, let me know once that it landed and I'll rebase around it. Much of the changes I'm looking at will actually supersede much of that one as I am moving quite a few pieces around.
addaleax commentedon Oct 30, 2017
@jasnell done!
jasnell commentedon Nov 1, 2017
After going through this for a few days, the changes I had in mind are just too significant of a change right now. There are also a few things that still need to be figured out in order to pull it off appropriately. I'm going to take a step back and figure out a more incremental approach.
grantila commentedon Nov 1, 2017
@jasnell keep #11552 in mind, please have a look at my comment about being able to detach
httpsockets. Since #16256, we can (re-)attach a socket to http1 or http2, but we might need to also provide aheadbuffer when constructing an Http2Session for "http1 upgrade" to work.apapirovski commentedon Nov 1, 2017
@jasnell Is there any other work in progress other than the PRs? I'm planning to take a look at some of the C++ code this week but don't want us to step on each other's toes.
jasnell commentedon Nov 2, 2017
addaleax commentedon Nov 28, 2017
@jasnell What's the status on this one? :)
jasnell commentedon Nov 28, 2017
In progress. Decided to split over multiple PRs. I've opened several up to this point, preparing another now.
jasnell commentedon Jan 8, 2018
This was done.