Repository navigation
test: good-second-contribution — tracking tests that need some more 💘 #14544
Description
A very biased list of tests that could enjoy some non-trivial refactoring
- Make test compliant with the test writing guide
- Make sure the test has a general description (PR or issue references most welcome)
- Make sure test cases are well separated (IIFE, functions, or just scopes) and documented
- Refactor away non-trivial micro-test-harnesses — example sequential/test-debugger-debug-brk.js
- Proper use of
test/commonutilities
new entries
- parallel/test-console.js - after console: coerce label to string in console.time() #14643 lands this test should assert the expected outputs. Currently it only checks that values are written to
stdoutand don't throw.
Activity
Trott commentedon Jul 30, 2017
#14541
refack commentedon Jul 30, 2017
I was thinking something more extensive, and obviously the "list" is going to get longer...
refack commentedon Jul 30, 2017
Like what you did in #14534
refack commentedon Jul 30, 2017
@nodejs/testing please add/remove/comment/edit
shivanth commentedon Jul 31, 2017
Can I take this up ?
refack commentedon Jul 31, 2017
Sure. If you need any help, ping me (here or on IRC).
Also if you find any other tests that are written in an outdated style, post them here, and I'll add them to the list.
oantoro commentedon Aug 9, 2017
Hi @refack
I am looking for an issue for my first contribution. May be I can work on this?
shivanth commentedon Aug 9, 2017
@okyantoro @refack A little with held upwith stuffs, Feel free to reassign this
oantoro commentedon Aug 9, 2017
I observed some test files and I found parallel/test-http-methods.js only covered GET, HEAD and POST and the last case compares the http.METHODS with http.METHODS.sort()
My question is why is just those three methods covered? Is it okay to add cases to check existence of other methods like PUT, DELETE etc?
Thanks
Trott commentedon Aug 10, 2017
Assuming it isn't duplicating another test that we already have, more test coverage is 👍
19 remaining items
juggernaut451 commentedon Feb 13, 2018
Anyone available for mentoring me regarding this issue? Would like to contribute
@refack @Trott @MylesBorins
BridgeAR commentedon Feb 13, 2018
@juggernaut451 a lot of our tests do not contain a description what they actually test. That would for example be a good thing to add.
Another thing that I am aware of is that our documentation lacks a lot of "changed" entries. The latter is probably quite some work though to check all the changes. Even though you probably only have to check the concrete API history and check when what API changed and if a changed entry was added or not.
BridgeAR commentedon Feb 13, 2018
Please also look at https://www.nodetodo.org/next-steps/
test: refactor parallel/test-tls-ca-concat.js
test: refactor parallel/test-tls-cert-chains-concat
test: refactor parallel/test-tls-cert-chains-concat
test: refactor parallel/test-tls-ca-concat.js
test: expanded assertions for console.timeEnd() output
test: refactor parallel/test-tls-ca-concat.js