test-icu-data-dir and test-fs-readdir-ucs2 failing on master #13986
Copy link
Copy link
Closed
Labels
armIssues and PRs related to the ARM architecture.Issues and PRs related to the ARM architecture.fsIssues and PRs related to file-system APIs and the fs module.Issues and PRs related to file-system APIs and the fs module.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
- Version: master
- Platform: Windows and ARM
- Subsystem: test
The last node-daily-master job https://ci.nodejs.org/job/node-test-commit/10810/ failed because of two tests. These failures appear to happen on every run of the surrounding runs of the relevant jobs, suggesting the failures are real.
parallel/test-icu-data-dirfails on Windowsparallel/test-fs-readdir-ucs2fails on Raspberry Pis (arm-fanned)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
armIssues and PRs related to the ARM architecture.Issues and PRs related to the ARM architecture.fsIssues and PRs related to file-system APIs and the fs module.Issues and PRs related to file-system APIs and the fs module.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Activity
tniessen commentedon Jun 29, 2017
9330835 appears to cause the problem in
test-icu-data-dir. If I revert the change totest-icu-data-dir.js, the test passes. Should be\r\non Windows.joaocgreis commentedon Jun 29, 2017
The
parallel/test-fs-readdir-ucs2failure is explained in nodejs/build#774 (comment) . PR to mark as flaky: #13989test: fix failure in test-icu-data-dir.js
joaocgreis commentedon Jun 30, 2017
This can be closed now, issues are no longer blocking CI.
parallel/test-icu-data-dirwas fixed in test: fix failure in test-icu-data-dir.js #13987parallel/test-fs-readdir-ucs2was marked flaky but we still need to find a better solution. Discussion can follow in now:node-test-binary-armdoesn't finish build#774test: fix failure in test-icu-data-dir.js
test: fix failure in test-icu-data-dir.js