Repository navigation
test: is parallel/test-https-client-get-url flaky on macOS #12873
Description
- Version:
master - Platform:
macOS - Subsystem: test
https://ci.nodejs.org/job/node-test-commit-osx/9598/nodes=osx1010/
655 parallel/test-https-client-get-url
duration_ms
0.315
severity
fail
stack
events.js:182
throw er; // Unhandled 'error' event
^
Error: connect ECONNREFUSED 127.0.0.1:51636
at Object.exports._errnoException (util.js:1026:11)
at exports._exceptionWithHostPort (util.js:1049:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1115:14)
/cc @nodejs/platform-macos
Activity
sebastianplesciuc commentedon May 6, 2017
Could this cause the issue? There are 3
getsandserver.close()is called for each of them.refack commentedon May 6, 2017
Which bring up the question, how did this ever work 😕 probablyy the 3
gets are buffered and the server has to deal with them before the 3 callback get toserver.close())sebastianplesciuc commentedon May 6, 2017
Can I call dibs on trying to fix it?
refack commentedon May 6, 2017
Of course. (good thing you did).
test: fix flaky test-https-client-get-url
refack commentedon May 10, 2017
Fixed by: #12876
test: fix flaky test-https-client-get-url