test-npm applicability #12836
Copy link
Copy link
Closed
Labels
docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.npmIssues and PRs related to the npm client dependency or the npm registry.Issues and PRs related to the npm client dependency or the npm registry.questionIssues asking questions about Node.js.Issues asking questions about Node.js.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
- Version: v8.0.0-pre
- Platform: all
- Subsystem: doc,test
What's the deal with make test-npm? Who is supposed to run that and when?
A lot of new folks have problems with it, and they're only running it because it's in BUILDING.md. I wonder if it should be moved in that doc, removed from that doc, annotated in that doc, or if it really is generally applicable and should be made more robust.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.npmIssues and PRs related to the npm client dependency or the npm registry.Issues and PRs related to the npm client dependency or the npm registry.questionIssues asking questions about Node.js.Issues asking questions about Node.js.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Activity
Fishrock123 commentedon May 4, 2017
Annotated? You should really only need to run it if you are upgrading npm. pretty much no one does that except from me and @MylesBorins at the current time.
It will not run/work on Windows. It does not pass on Linux as of the latest time someones tried it. (Alpine, maybe?)
Since it is not suitable for our CI (I think it still makes network calls? maybe cc @nodejs/npm) it is run on our local macOS machines prior to an npm upgrade.
addaleax commentedon May 4, 2017
I’d say so, yes
Fwiw the npm tests doesn’t pass for me on Linux until npm/npm#16474 gets merged even outside of
make test-npm😄doc: remove test-npm from general build doc
Trott commentedon May 4, 2017
PR submitted. This isn't a bug report (or is only sort of a bug report), just a question, so I'm going to close it.
doc: remove test-npm from general build doc
doc: remove test-npm from general build doc
doc: remove test-npm from general build doc
doc: remove test-npm from general build doc