installer will not overwrite user's .npmrc, even if invalid #12345

Activity

1. aqrln

   added

   installIssues and PRs related to installing Node.js and its installers.Issues and PRs related to installing Node.js and its installers.

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on Apr 11, 2017
2. aqrln commented on Apr 11, 2017

   

   aqrln

   on Apr 11, 2017

   Last edited by aqrln

   Contributor

   More actions

   node -v prints: 4.2.0

   Just to be sure I've understood you correctly: the Node.js binary itself is in the PATH, but the globally installed packages are not?
3. aladdin-add commented on Apr 11, 2017

   

   aladdin-add

   on Apr 11, 2017

   Last edited by aladdin-add

   Author

   More actions

   yes.

   PATH

   PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files\TortoiseGit\bin;C:\Users\hh\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\nodejs\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\Git\cmd;C:\Users\hh\Anaconda3;C:\Users\hh\Anaconda3\Scripts;C:\Users\hh\Anaconda3\Library\bin;C:\Program Files (x86)\Microsoft VS Code\bin;C:\Users\hh\AppData\Roaming\搜狐影音\5.0.2.5;c:\Python27;C:\Users\hh\AppData\Local\Microsoft\WindowsApps;C:\Users\hh\AppData\Roaming\npm;C:\Program Files (x86)\Microsoft VS Code Insiders\bin
   

   npm prefix -g

   C:\Program Files\nodejs
   
4. aladdin-add commented on Apr 11, 2017

   

   aladdin-add

   on Apr 11, 2017

   Last edited by aladdin-add

   Author

   More actions

   npm/npm#16313
5. aqrln commented on Apr 11, 2017

   

   aqrln

   on Apr 11, 2017

   Contributor

   More actions

   Shouldn't npm prefix -g be C:\Users\hh\AppData\Roaming\npm on your system? At least, that's what I'd suppose looking at your PATH. Well, I don't think my Windows knowledge is sufficient to make a conclusion about whether it is a genuine installer bug or some other issue related to your system or, probably, prior configuration, so let's wait for Windows people here, maybe @refack.

   Looking at the thread in the NPM repo and the original post here:

   npm -v prints: v7.8.0
   node -v prints: 4.2.0

   I suppose, it's all the other way around. Can you please update your comment so that it's not confusing about which version of Node the issue is related to?
6. aladdin-add

   changed the title [-]the Nodejs installer can not set the right `PATH` on window 10 [/-] [+]the Nodejs installer can not set the right `PATH` on windows 10 [/+] on Apr 11, 2017
7. refack commented on Apr 11, 2017

   

   refack

   on Apr 11, 2017

   Contributor

   More actions

   From first look it seems like prior configuration. There are afew issues I can see:

   1. Path=...C:\Program Files (x86)\nodejs\...
   2. Path=...C:\Users\hh\AppData\Roaming\npm...
   3. npm prefix -g
> C:\Program Files\nodejs

   • You're current node is x86 (32 bit) but your npm prefix is for the x64 directory.
   • a non default npm prefix implies an npmrc somewhere

   @aladdin-add can you run npm config list
8. refack commented on Apr 11, 2017

   

   refack

   on Apr 11, 2017

   Contributor

   More actions

   Now where the installer should cleanup (override) prior configuration? definatly an edge-case.
   Maybe low priority bug, or feature request (check box in installer to Force Override)
9. refack commented on Apr 11, 2017

   

   refack

   on Apr 11, 2017

   Last edited by refack

   Contributor

   More actions

   P.S. Anyone remembers why the npm folder is in the PATH? the global npm folder is in the PATH for the bin shims.
10. aladdin-add commented on Apr 11, 2017

    

    aladdin-add

    on Apr 11, 2017

    Author

    More actions

    c:\tt>npm config list
    ; cli configs
    scope = ""
    user-agent = "npm/4.2.0 node/v7.8.0 win32 x64"
    
    ; userconfig C:\Users\hh\.npmrc
    cache = "C:\\Program Files\\nodejs\\cache"
    prefix = "C:\\Program Files (x86)\\nodejs"
    registry = "http://registry.npm.taobao.org/"
    
    ; builtin config undefined
    
    ; node bin location = C:\Program Files (x86)\nodejs\node.exe
    ; cwd = c:\tt
    ; HOME = C:\Users\hh
    ; "npm config ls -l" to show all defaults.
    
11. refack commented on Apr 11, 2017

    

    refack

    on Apr 11, 2017

    Last edited by refack

    Contributor

    More actions

    So the installer will not override an existing .npmrc (in your case C:\Users\hh\.npmrc)
    You can edit it yourself; either set a prefix, or remove the line to fall back to the default (C:\Users\hh\AppData\Roaming\npm)
    Also you have a non default registry, and your cache is in an administrator access folder

    Ohh, or run npm config set prefix xxxxxxxxxxx
12. aladdin-add commented on Apr 11, 2017

    

    aladdin-add

    on Apr 11, 2017

    Last edited by aladdin-add

    Author

    More actions

    thanks. I'm not sure whether the .npmrc is manually created.
    we can give users an option to select override prior configuration or not. you recon?
13. refack

    added

    feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.

    on Apr 11, 2017
14. refack commented on Apr 11, 2017

    

    refack

    on Apr 11, 2017

    Last edited by refack

    Contributor

    More actions

    .npmrc in the user directory can created by npm config set with no -g
    For now the installer will not change user customization (via .npmrc or etc/npmrc), so enabling overriding is a feature request.
    Also a good option is to validate that the value of npm prefix -g is writable (that may be an npm feature)
15. refack

    changed the title [-]the Nodejs installer can not set the right `PATH` on windows 10 [/-] [+]installer will not override user's .npmrc, even if invalid[/+] on Apr 11, 2017
16. refack commented on Apr 11, 2017

    

    refack

    on Apr 11, 2017

    Last edited by refack

    Contributor

    More actions

    Renamed issue and marked "feature request", also IMHO not specifically a windows issue.
17. refack

    removed

    windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

    on Apr 11, 2017
18. refack

    changed the title [-]installer will not override user's .npmrc, even if invalid[/-] [+]installer will not overwrite user's .npmrc, even if invalid[/+] on Apr 11, 2017
19. Fishrock123 commented on Apr 12, 2017

    

    Fishrock123

    on Apr 12, 2017

    Contributor

    More actions

    I don't think we specifically set the .npmrc at all.
20. refack commented on Apr 12, 2017

    

    refack

    on Apr 12, 2017

    Last edited by refack

    Contributor

    More actions

    @Fishrock123 if the user uninstalls node will not /etc/npmrc be removed?
21. Fishrock123 commented on Apr 12, 2017

    

    Fishrock123

    on Apr 12, 2017

    Contributor

    More actions

    There is no MacOS uninstaller, and the Windows one lives here if you can find anything in there: https://github.com/nodejs/node/tree/master/tools/msvs/msi
22. refack commented on Apr 12, 2017

    

    refack

    on Apr 12, 2017

    Last edited by refack

    Contributor

    More actions

    Windows one lives here if you can find anything in there: https://github.com/nodejs/node/tree/master/tools/msvs/msi

    It is the wix logic not to removes files it does not know. So to answer my own question: no. (changed comment above)
23. bnoordhuis commented on Oct 5, 2017

    

    bnoordhuis

    on Oct 5, 2017

    Member

    More actions

    It's been six months with no movement and it doesn't strike me as an installer bug in the first place. Should we close this?
24. apapirovski

    closed this as completedon Apr 13, 2018