Repository navigation
crypto: sign/verify support for RSASSA-PSS #1127
Description
It would be good if the crypto.createSign / crypto.createVerify implementations supported different openssl padding schemes instead of the default PKCS1.5. Specifically, I'm interested in PSS and PSS with MGF1.
RSA_padding_add_PKCS1_PSS
RSA_padding_add_PKCS1_PSS_mgf1
I found the following forum post that may help in the development effort.
http://openssl.6102.n7.nabble.com/RSA-sign-and-verify-td44219.html
I'm a bit out of my depth with C++, however I'm willing to help implement if someone could point me in the right direction with crypto.cc.
Thanks
Activity
wolfie82 commentedon Mar 12, 2015
I did a bit more digging. It might be easier to update node_crypto.cc to use the later OpenSSL EVP API's.
EVP_Sign*&EVP_Verify*toEVP_DigestSign*&EVP_DigestVerify*Then it should be a matter of calling
EVP_PKEY_CTX_set_rsa_padding()with 'RSA_PKCS1_PSS_PADDING' &EVP_PKEY_CTX_set_rsa_pss_saltlen()The only thing I'm a bit unsure of is MGF1.
[-]Crypto sign support for RSASSA-PSS[/-][+]crypto: sign/verify support for RSASSA-PSS[/+]James-Firth commentedon Jan 4, 2016
+1 I would appreciate this feature, and it would help keep node compatible with more products in the future as adoption grows.
Trott commentedon Jun 24, 2016
@nodejs/crypto Any thoughts on this? Specifically, is this a reasonable feature to include in core? And given as the issue is more than a year old, has anything changed that might make this issue obsolete? ("Oh, we already added support for that six months ago!")
bnoordhuis commentedon Jun 24, 2016
No strong opinion. I think it could be retrofitted onto
crypto.createSign()andcrypto.createVerify().PSS appears to be rare. Not a reason to reject it but it is arguably a reason to not spend too much effort on it. I'd be interested in hearing use cases.
Not strictly necessary. They're aliases for their EVP_Digest counterparts in OpenSSL 1.1.0.
mwain commentedon Oct 25, 2016
Is there any movement on this? I have a requirement to use
SHA256withRSA/PSSbut its not supported in node crypto.bnoordhuis commentedon Oct 25, 2016
@mwain No movement whatsoever.
mwain commentedon Oct 25, 2016
Would it be considered if i put something together?
bnoordhuis commentedon Oct 25, 2016
If it's not too intrusive I don't see why not. I'm curious what your use case is though.
mwain commentedon Oct 25, 2016
Ok, you mentioned it might be able to be retrofitted into
crypto.createSign()/crypto.createVerify()but they have an extra paramoptionswhich is passed tostream.Writable, which is not documented :/So i was thinking of adding an extra function to each to set padding type and option padding length?
bnoordhuis commentedon Oct 25, 2016
That sounds reasonable. Documenting and extending
optionsis probably acceptable too.6 remaining items
crypto: add sign/verify support for RSASSA-PSS
crypto: add sign/verify support for RSASSA-PSS
crypto: add sign/verify support for RSASSA-PSS
crypto: add sign/verify support for RSASSA-PSS
crypto: add sign/verify support for RSASSA-PSS
Abhishek2kr commentedon Oct 12, 2019
Can you help me to use SHA256withRSA/PSS ? @mwain
crypto: add sign/verify support for RSASSA-PSS