Skip to content

Linter rule: use ASCII quotes not Unicode ones #11209

Closed
Closed
Linter rule: use ASCII quotes not Unicode ones#11209
Labels
good first issueIssues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.

Description

@gibfahn
gibfahn
opened on Feb 7, 2017
  • Subsystem: eslint

See: #11129 (comment)

I added a second commit that replaces a few U+2019 quotes with ASCII quotes so that their files can be stored as one-byte strings.
Probably one for another PR, but this sounds like a good candidate for a lint rule.

Basically we need a lint rule that checks for U+2019 quotes: ’, and suggests that they be replaced with ASCII quotes: '.

cc/ @bnoordhuis @richardlau

Activity

  1. gibfahn
    added
    good first issueIssues that are suitable for first-time contributors.
    on Feb 7, 2017
  2. addaleax
    added
    toolsIssues and PRs related to the tools directory.
    on Feb 7, 2017

  3. addaleax commented on Feb 7, 2017

    @addaleax
    addaleax
    on Feb 7, 2017
    Member

    Two things:

    • This should apply to lib/ and only to lib/, because that’s where we need it.
    • This isn’t really about quotation marks; ideally, any non-ASCII character would be forbidden (sigh)…

  4. silverwind commented on Feb 7, 2017

    @silverwind
    silverwind
    on Feb 7, 2017
    Contributor

    We could do something like this (match is fed to the RegExp constructor):

    - match: '’'
  replacement: '\''
- match: '[—–]'
  replacement: '-' 
- match: '[^\x00-\x7F]'
  replacement: ''

    The last one might be a bit extreme :)

  5. aqrln commented on Feb 7, 2017

    @aqrln
    aqrln
    on Feb 7, 2017
    Contributor

    @silverwind I'd also add replacements for “” and «» to ASCII double quotes.

  6. silverwind commented on Feb 7, 2017

    @silverwind
    silverwind
    on Feb 7, 2017
    Contributor

    You can always contribute improvements later, above is just about the general rule config layout.

  7. gibfahn commented on Feb 8, 2017

    @gibfahn
    gibfahn
    on Feb 8, 2017
    MemberAuthor

    I'd also add replacements for “” and «» to ASCII double quotes.

    This is an open issue looking for someone to raise a PR. If whoever raises it wants to include those then that sounds good to me.

  8. not-an-aardvark commented on Feb 10, 2017

    @not-an-aardvark
    not-an-aardvark
    on Feb 10, 2017
    Contributor

    If the goal is to allow files to be stored as one-byte strings, would it be better for the rule to just disallow all non-ascii characters in files?

    edit: Never mind, I see @addaleax also mentioned this above.

  9. hkal commented on Feb 10, 2017

    @hkal
    hkal
    on Feb 10, 2017

    @gibfahn I'll give this a go if no one else is assigned.

  10. gibfahn commented on Feb 10, 2017

    @gibfahn
    gibfahn
    on Feb 10, 2017
    MemberAuthor

    @hkal go for it!

  11. hkal commented on Feb 14, 2017

    @hkal
    hkal
    on Feb 14, 2017

    Do we still need this after #11129?

    cc @bnoordhuis

  12. bnoordhuis commented on Feb 14, 2017

    @bnoordhuis
    bnoordhuis
    on Feb 14, 2017
    Member

    Would be good to enforce it because Unicode files take up twice as much space in the binary as plain ASCII files.

  13. 10 remaining items

  14. SirR4T
    added a commit that references this issue on Jan 19, 2018

    tools: non-Ascii linter for /lib only

    3d63b03
  15. addaleax
    closed this as completedin c45afe8on Feb 4, 2018
  16. MylesBorins
    added 3 commits that reference this issue on Feb 21, 2018

    tools: non-Ascii linter for /lib only

    46b8481

    tools: non-Ascii linter for /lib only

    e1fffbc

    tools: non-Ascii linter for /lib only

    e00bb16
  17. SirR4T
    added 2 commits that reference this issue on Mar 29, 2018

    tools: non-Ascii linter for /lib only

    6ba7fd0

    tools: non-Ascii linter for /lib only

    bc22bf0
  18. BethGriggs
    added a commit that references this issue on Apr 10, 2018

    tools: non-Ascii linter for /lib only

    016a28a
  19. MayaLekova
    added a commit that references this issue on May 8, 2018

    tools: non-Ascii linter for /lib only

    ee8bdf3
  20. sjarmak
    added a commit that references this issue on Jul 27, 2026

    tools: non-Ascii linter for /lib only

    c45afe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions