Proposal: http: automaticly send Content-Length header when possible

I propose we make http set the Content-Length header when the user does only call OutgoingMessage.prototype.end and not write or writeHead.

Eg.

require('http').createServer(function (req, res) {
  res.end('Hello World')
}).listen(1337)

HTTP/1.1 200 OK
Date: Tue, 03 Mar 2015 19:42:18 GMT
Connection: keep-alive
Content-Length: 11

Hello World

It is a trivial change in lib/, but breaks a lot of tests.

It breaks 20 tests, but mostly it looks like trivial stuff like:

AssertionError: { date: 'coffee o clock', 'content-length': '10' } deepEqual { date: 'coffee o clock' }

Sending content-length here seams like it should be expected, given .write()'s automatic headers behaviour.

Seems reasonable to me. It would save a few bytes per response as well.

Ok, I'll see if I can get something ready later tonight or tomorrow.

http: send Content-Length when possible

Navigation Menu