Repository navigation
Blockers for the update to V8 8.0 #127
Description
We've got quite a few things to fix this time!
- Failing test-inspector-multisession-ws
- Failing test-assert
- S390x fails to build
- FreeBSD fails to build
- SmartOS fails to build
- Windows fails to build (VS2019)
- Windows fails to build (VS2017)
- Broken debug build
- incomplete zlib.gyp
- V8 zlib target fails for cross-compilation
- Debug build not working without
--experimental-enable-pointer-compression
Activity
bnoordhuis commentedon Dec 17, 2019
@targos Does #130 (comment) mean that the "incomplete zlib.gyp" bullet point should be checked off?
targos commentedon Dec 17, 2019
@bnoordhuis I suppose we can check it off because it's no longer a blocker, but I didn't implement the conditions to load optimized code depending on the platform.
gengjiawen commentedon Jan 18, 2020
Yeap. We have just fixed build issue on vs2019. Still some work todo. See #127 (comment) for update.
SFx2018 commentedon Jan 24, 2020
any news? :D looking forward for it :D
addaleax commentedon Jan 24, 2020
@SFx2018 There is a checklist at the top of this PR :)
hashseed commentedon Feb 6, 2020
V8 had to make some changes to make building with zlib work again: https://chromium-review.googlesource.com/c/v8/node-ci/+/2037570
SFx2018 commentedon Feb 10, 2020
any ETA for release for nodejs?
gengjiawen commentedon Feb 27, 2020
vs2017 build issue has been resolved.
targos commentedon Feb 27, 2020
CI: https://ci.nodejs.org/view/MyJobs/job/node-test-commit-node-v8/450/
gengjiawen commentedon Mar 4, 2020
With #147 and #140 fixed in upstream, hopefully we have only two test case failed.
liudonghua123 commentedon Mar 4, 2020
Glad to here that, I hope I can use v8 8.0 as soon as possible. :haha:
mmarchini commentedon Mar 4, 2020
#120 was not fixed upstream yet though :/
gengjiawen commentedon Mar 5, 2020
got it wrong, should be #140
MKRhere commentedon Mar 18, 2020
#140 is closed (fixed upstream), should the last point be checked off?
gengjiawen commentedon Mar 19, 2020
V8 8.1 landed on Node.js master (nodejs/node#32116).
mmarchini commentedon Mar 19, 2020
Yes, this can be closed now. Hooray!