Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

Doesn't work on pull requests that don't have the mergeability-details container at the bottom #1

Closed

Description

@evanlucas

With the transition to the new review based system, some pull requests do not have a div with the mergeability-details class. This class is what we currently use for the new reviews.

A workaround could be to look in the comments that are approval comments?

Activity

  1. thefourtheye commented on Oct 9, 2016

    @thefourtheye

    You mean when there is a merge conflict?

  2. evanlucas commented on Oct 12, 2016

    @evanlucas
    ContributorAuthor

    No, there are a few pull requests that I tried it on that did not have the container at the bottom of the PR. Now that I am trying to find one though, I'm having trouble. I'll keep looking and update when I do find one.

  3. evanlucas commented on Oct 12, 2016

    @evanlucas
    ContributorAuthor

    ok, so I'm really not sure what's going on now as nodejs/node#9041 works in Chrome 52, but doesn't show all reviewers in Chrome 53. I'll keep digging

  4. evanlucas commented on Oct 12, 2016

    @evanlucas
    ContributorAuthor

    This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions