This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Repository navigation
Add support for nodereport on AIX - #17
Closed
rnchamberlain wants to merge 2 commits into
Closed
rnchamberlain wants to merge 2 commits into
rnchamberlain wants to merge 2 commits into
Conversation
mhdawson
approved these changes
Nov 4, 2016
Member
|
Unless there are any objections will plan to land this tomorrow. |
Member
|
Changes look good. Compilation is successful and tests are passing with the exception of test 3, which I believe will be addressed by #16. |
Member
|
Maybe also update |
1. features.h and execinfo.h do not exist 2. backtrace() API is not available, native stacks disabled 3. ru_utime.tv_usec is int (same as OSX) 4. ulimit RLIMIT_MEMLOCK is not available 5. PRIu64 macro is not available
Contributor
Author
|
Rebased and updated README to list AIX as supported. |
mhdawson
pushed a commit
that referenced
this pull request
Nov 9, 2016
1. features.h and execinfo.h do not exist 2. backtrace() API is not available, native stacks disabled 3. ru_utime.tv_usec is int (same as OSX) 4. ulimit RLIMIT_MEMLOCK is not available 5. PRIu64 macro is not available PR-URL: #17 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as bcf3a33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@richardlau FYI