This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Repository navigation
Fix build on Windows with libuv 1.22 and later - #118
Closed
richardlau wants to merge 1 commit into
Closed
richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
On Windows in libuv 1.22 and later the `due` member was renamed to `timeout` for consistency with the other platforms. Fixes: #113
Member
Author
|
CI against Node.js 10: https://ci.nodejs.org/job/nodereport-continuous-integration/258/ ✔️ |
This was referenced Dec 19, 2018
Member
Author
|
Needs a review. cc @nodejs/diagnostics @nodejs/platform-windows @targos |
cjihrig
approved these changes
Jan 11, 2019
richardlau
added a commit
to richardlau/nodereport
that referenced
this pull request
Jan 22, 2019
On Windows in libuv 1.22 and later the `due` member was renamed to `timeout` for consistency with the other platforms. PR-URL: nodejs#118 Fixes: nodejs#113 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
Author
|
Landed in a696eb0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows in libuv 1.22 and later the
duemember was renamedto
timeoutfor consistency with the other platforms.Fixes: #113