Repository navigation
threadsafe: RunInNodeThread #413
Description
Beside wrapping napi_*_threadsafe I'd also love to see a RunInNodeThread implementation in node-addon-api as an enabler for "concurrent processing" / multithreading and modern C++ with NAPI.
- see a usage example here
- and a possible implementation here
As napi_threadsafe.. API is not fire and forget, but creates objects etc., I wrapped everything in a class which must live on the heap, but threadsafe objects are created once and reused.
The main idea is that we can run RunInNodeThread from any thread:
void js_fn(const Napi::CallbackInfo& info) {
// persist callback info[0]
std::thread([cb_ref]() { // or a thread pool or Rx
int result = heavyProcessing();
RunInNodeThread([result, cb_ref](Napi::Env env) {
// callback cb_ref with result in node thread
});
}
}What do you think?
Activity
github-actions commentedon Dec 17, 2020
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
mhdawson commentedon Jan 15, 2021
We should keep this open, team will try to review so we can discuss in next weeks meeting.
mhdawson commentedon Jan 22, 2021
Discussed in the team meeting today. It seems useful, but might fit better in a supporting library and would be a good candidate if we had one that we used to provide wrapper type functions. Unfortunately we don't have that yet.
mhdawson commentedon Feb 12, 2021
We discussed again in todays meeting and the what we agreed:
Is one of those something that you'd be interested in?
mhdawson commentedon Feb 12, 2021
@DaAitch
DaAitch commentedon Feb 12, 2021
@mhdawson I think that's a good idea.
At current I have no idea when I'll have time to contribute, so I'd be happy (if someone is interested in the idea) to continue it and feel free to use any code sample, ideas etc. to contribute.
I'll close this.