You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
Invited
Loaders team: @nodejs/loaders
Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
We were hoping to clean up a bunch of things as part of the switch to --default-type=module by default, namely cutting out some “include the CommonJS loader here to allow for monkey patching” hacks that have had TODOs to deprecate for years. If detection becomes the new way forward, how will we do this cleanup? Perhaps we set the module customization hooks stable by December hopefully, and just do the cleanup as a semver-major to ship in 22.0.0?
I think the next big goal for regular modules code would be to finally remove the CommonJS loader. That means getting all the tests to pass if shouldUseESMLoader always returns true (as in, we use the ESM loader for all entry points). Currently I get 154 failures if you do this; the bulk of these are async_hooks tests that fail because of async resources created by the ESM loader as part of startup. See [DO NOT MERGE] test: duplicate async_hooks tests in esm node#44323.
Activity
GeoffreyBooth commentedon Oct 21, 2023
Anything we want to discuss?
Next steps after esm: detect ESM syntax in ambiguous JavaScript node#50096: should we remove
--experimental-default-typenow? I don’t see the point of having it if we have ESM syntax detection?We were hoping to clean up a bunch of things as part of the switch to
--default-type=moduleby default, namely cutting out some “include the CommonJS loader here to allow for monkey patching” hacks that have had TODOs to deprecate for years. If detection becomes the new way forward, how will we do this cleanup? Perhaps we set the module customization hooks stable by December hopefully, and just do the cleanup as a semver-major to ship in 22.0.0?I think the next big goal for regular modules code would be to finally remove the CommonJS loader. That means getting all the tests to pass if
shouldUseESMLoaderalways returnstrue(as in, we use the ESM loader for all entry points). Currently I get 154 failures if you do this; the bulk of these areasync_hookstests that fail because of async resources created by the ESM loader as part of startup. See [DO NOT MERGE] test: duplicate async_hooks tests in esm node#44323.Import Maps Implementation Plan #168
module: improve external format support node#49704
ESM Loader Hooks (20.8) should support a more testable, less stateful design node#50042
module: initialize hook returns load, resolve node#50044
JakobJingleheimer commentedon Oct 23, 2023
I feel like there are some open questions for initialize's return and external formats. Perhaps we quickly discuss those?
I the we're in agreement for the rest—they're just a matter of doing it.
GeoffreyBooth commentedon Oct 23, 2023
Sure. @ggoodman, are you available to join this meeting?
ggoodman commentedon Oct 23, 2023
Sure, I'll try to make it.
GeoffreyBooth commentedon Oct 24, 2023
#169