http2: status of push API #67

Activity

1. mcollina

   changed the title [-]http2: status of push[/-] [+]http2: status of push API[/+] on May 4, 2017
2. robertkowalski commented on May 4, 2017

   

   robertkowalski

   on May 4, 2017

   Last edited by robertkowalski

   Contributor

   More actions

   Question: Do we want to support legacy APIs?

   test-http-set-cookies.js uses a currently not documented way to set headers (note the nested array instead of a flat object):

       res.writeHead(200, [['set-cookie', 'A'],
                           ['set-cookie', 'B'],
                           ['content-type', 'text/plain']]);

   I'm in favor of just supporting objects. However I remember somehow from this morning that the goal is to support as much of the old behaviour as possible. What do you think @nodejs/http2 ?
3. mcollina commented on May 4, 2017

   

   mcollina

   on May 4, 2017

   SponsorMemberAuthor

   More actions

   @robertkowalski I'd focus on documented behavior.
4. jasnell commented on May 5, 2017

   

   jasnell

   on May 5, 2017

   Member

   More actions

   For now, definitely focus on documented behavior. We can revisit this once we have that done and working.
5. sebdeckers commented on May 6, 2017

   

   sebdeckers

   on May 6, 2017

   Contributor

   More actions

   🤔 Is this issue discussing server push support or header API compatibility?

   The compatibility layer in #47 tries to stay true to the documented APIs, for headers on the request and response. Cookies are not yet supported. I don't think it's prohibitively difficult but would rather leave it for a separate PR.

   FWIW, core currently uses an Object for headers and trailers. That could be changed to using a Map or linked list.
6. mcollina commented on May 19, 2017

   

   mcollina

   on May 19, 2017

   SponsorMemberAuthor

   More actions

   I think we can close this now.
7. mcollina

   closed this as completedon May 19, 2017