You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ones who has read/write access to the github-bot secrets are a subset of the build WG, I'd ping @joyeecheung@maclover7@rvagg.
For ref these secrets are defined in build/github-bot/deployment_secrets.md inside the secrets repo and used together with the create-github-bot.yml playbook.
OK, figured it out. Login credentials for nodejs-github-bot are in secrets/build/github-bot/github_bot_account.md. So I've logged in to Jenkins as that and made a new API token there. It's now in secrets/build/github-bot/deployment_secrets.md and also on the gh-bot server and I've restarted its services.
Activity
[-]need to generate a new token[/-][+]need to generate a Jenkins API new token[/+]phillipj commentedon Nov 18, 2018
I don't have privileges do see those tokens anymore, so I can't help update them.
FYI all the secrets the bot gets provided as environment variables are defined in the secrets repo.
richardlau commentedon Nov 19, 2018
Is that a @nodejs/build-infra issue then?
phillipj commentedon Nov 19, 2018
The ones who has read/write access to the github-bot secrets are a subset of the build WG, I'd ping @joyeecheung @maclover7 @rvagg.
For ref these secrets are defined in
build/github-bot/deployment_secrets.mdinside the secrets repo and used together with the create-github-bot.yml playbook.refack commentedon Nov 19, 2018
BTW: that group might need a refresh - nodejs/build#1575
maclover7 commentedon Nov 19, 2018
I can take a look at this in the next day or so
rvagg commentedon Nov 21, 2018
OK, figured it out. Login credentials for nodejs-github-bot are in secrets/build/github-bot/github_bot_account.md. So I've logged in to Jenkins as that and made a new API token there. It's now in secrets/build/github-bot/deployment_secrets.md and also on the gh-bot server and I've restarted its services.
Documented some of this in the user description @ https://ci.nodejs.org/user/nodejs-github-bot/
What's the best way to test this or do I just watch for the next PR to see if it's worked?
refack commentedon Nov 21, 2018
Works: nodejs/node#24538