Repository navigation
Conversation
There was a problem hiding this comment.
"commandline" probably isn't a word on its own. Maybe "command line" or "command-line"?
|
Thanks @bengl for the feedback. I tried to address both your points. |
|
Alright this gets a 👍 from me. Can we get another another reviewer from @nodejs/documentation on this? |
There was a problem hiding this comment.
As a document for beginners, it might be best to lead with a more concrete example of the problem we're trying to solve before introducing the solution.
There was a problem hiding this comment.
Sounds good. Would you say the problem we're trying to solve is "synchronous programming" or "misunderstanding about asynchronous programming"? (The later is much easier to demonstrate/explain I think 😄 )
This is a first attempt at describing asynchronous programming in node.js. It attempts to at least mention all considerations. It also attempts to present experience and best-practices when such are clear. This fixes issue #20.
|
OK, I think/hope I've addressed all feedback, and this is ready for another round of review. |
|
Hey @drewfish can you resubmit this against https://github.com/nodejs/nodejs.org ? |
|
@bengl submitted as nodejs/nodejs.org#422 |
There was a problem hiding this comment.
doesn't setTimeout just take a this parameter?
|
Closing this since we won't be merging this into this repo, but probably |
This is a first attempt at describing asynchronous programming in node.js. It
attempts to at least mention all considerations. It also attempts to present
experience and best-practices when such are clear.
This fixes issue #20.