Repository navigation
V8's CpuProfiler uses busy wait on Windows. #170
Description
The reason for that is described in this comment:
// Do not use Sleep on Windows as it is very imprecise.
// Could be up to 16ms jitter, which is unacceptable for the purpose.
This in turn is not acceptable for some APM vendors who run the CpuProfiler in production. For sampling intervals significantly larger than 16ms we should be fine with using Sleep though.
Activity
hashseed commentedon Feb 22, 2018
Upstream fix is in flight: https://chromium-review.googlesource.com/c/v8/v8/+/931102
hashseed commentedon Feb 22, 2018
@Flarna @Hollerberg feel free to have this cherry-picked onto Node.js. I don't think we will backmerge this change in V8 upstream.
[profiler] use Sleep() on windows for long profile intervals.
Flarna commentedon Feb 28, 2018
@hashseed Thanks for the change!
But I think there is an else missing in current code. Now there is no wait at all for long intervals...
deps: v8: cherry-pick fixes for v8:7535
Flarna commentedon Jul 9, 2019
Will close this as this is included in NodeJS 10 onwards.