Repository navigation
fix: await signature verification before installing package managers - #927
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Signed-off-by: Aschenbath <Aschenbath@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact-version installations can finish before asynchronous signature verification completes, allowing a package manager with invalid signatures to run and enter the cache. This also breaks registries such as Artifactory that omit
dist.signatureson the version endpoint and require the package-root metadata fallback introduced in #870.installVersionbefore checking the integrity hash, writing cache metadata, or running the package manager, and remove the temporary download if verification or metadata lookup fails.corepack useassertions to match errors reported through Clipanion after awaiting verification.Validation (Node.js v24.20.0, repository
node_modules):node node_modules/typescript/bin/tsc --noEmit— passed.node node_modules/eslint/bin/eslint.js— passed.tests/main.test.ts:75already usesit.failsfor rejecting a known package-manager URL inpackage.json(also present in the base commit).The test command below isolates lowercase proxy variables from the sandbox, disables inherited proxy setup for CLI children, and enables the required egress proxy for Vitest workers' live npm key check:
Implementation and automated validation were performed with Codex.
Closes #725