Repository navigation
jose@v4.15.2 not working on Node v21.x #1011
Description
Hi @panva I noticed you're listed as maintainer for jose so I'd like to bring to your attention that jose@v4.15.2 tests have been failing across different systems on v21.x. Feel free to loop in more contributors that you think may help.
Here a failed run for reference:
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3318/testReport/
As you can see on this run jose is failing on five different nodes. Can you please help us to debug the issue? I'm not sure if this is related to the new Node version or something inside the package.
Activity
panva commentedon Oct 11, 2023
Hi, i'll take a look. This is unexpected since there are no crypto changes in v21
alfonsograziano commentedon Oct 11, 2023
Thanks :) Please let me know if I can support you!
panva commentedon Oct 11, 2023
What changed wrt zlib's inflateRaw/deflateRaw?
alfonsograziano commentedon Oct 11, 2023
Not sure, maybe this can be related? https://github.com/nodejs/node/pull/50085/files
I see that has been merged yesterday and also the jose issue started yesterday
panva commentedon Oct 11, 2023
Installing v21.0.0-nightly20231009387e2929fe on my local macOS system does not reproduce this issue. I suspect them to be platform related and they seem to be related to
inflateRaw, anddeflateRawoutputs from thenode:zlibmodule.The issue is that the test vector is deterministic and therefore expects a specific output, which on these runs was not provided.
panva commentedon Oct 11, 2023
Yes, that's absolutely related.
panva commentedon Oct 11, 2023
I'm compiling from main now.
alfonsograziano commentedon Oct 11, 2023
Do you have any idea to fix the issue? Unfortunately my knowledge for now is not enough to figure out a proper solution by myself
panva commentedon Oct 11, 2023
I'll compile from main to see if it's platform dependent or not, then we ask for the zlib update to be reverted.
alfonsograziano commentedon Oct 11, 2023
Awesome, thanks!
panva commentedon Oct 11, 2023
Opened nodejs/node#50138
panva commentedon Oct 11, 2023
I will mark the test as non-deterministic and release a patch release to unblock citgm.
panva commentedon Oct 11, 2023
@alfonsograziano I've adjusted the test expectation and released v4.15.3, you can close this.
alfonsograziano commentedon Oct 12, 2023
Awesome, thanks a lot!