Repository navigation
Conversation
Keep SmartOS in daily and release runs by limiting the exclusion to GIT_REMOTE_REF pull refs and test builds. Refs: nodejs#4457 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
sxa
reviewed
Oct 15, 2026
| // SmartOS ----------------------------------------------- | ||
| // Not run for pull requests, node-daily-* still covers them | ||
| // https://github.com/nodejs/build/issues/4457 | ||
| [ /^smartos/, prTestType, allVer ], |
Member
There was a problem hiding this comment.
Could we still allow it to be run on codestreams other than main? My gut feel is that this would still be containable.
Suggested change
| [ /^smartos/, prTestType, allVer ], | |
| [ /^smartos/, prTestType, gte(27) ], |
Member
Author
There was a problem hiding this comment.
Your suggestion is not the same as "other than main" though is it?
Member
There was a problem hiding this comment.
Not explicitly - it was an (untested) approximation to achieve something equivalent today based on the current versions which should help alleviate concerns with the amount of time that node-test-pull-request can take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep SmartOS in daily and release runs by limiting the exclusion to GIT_REMOTE_REF pull refs and test builds.
Refs: #4457
Refs: #4458
Assisted-by: Codex
cc @richardlau @sxa this is #4458 scoped down to just smartos