Repository navigation
Conversation
Fixes: nodejs/postject#62 Signed-off-by: Darshan Sen <raisinten@gmail.com>
83f7ca5 to
0a43ee7
Compare
RaisinTen
changed the title
| sh(script: "git clone https://github.com/emscripten-core/emsdk.git", returnStatus: true) | ||
| sh(script: "(cd emsdk && ./emsdk install latest)", returnStatus: true) | ||
| sh(script: "(cd emsdk && ./emsdk activate latest)", returnStatus: true) | ||
| sh(script: "(cd emsdk && source ./emsdk_env.sh && cd .. && npm run build -- --jobs=3)", returnStatus: true) |
There was a problem hiding this comment.
What if this step fails? What returnStatus supposedly does?ß
There was a problem hiding this comment.
Normally, a script which exits with a nonzero status code will cause the step to fail with an exception. If this option is checked, the return value of the step will instead be the status code. You may then compare it to zero, for example.
From: https://www.jenkins.io/doc/pipeline/steps/workflow-durable-task-step/
As we didn't check it in any, we could probably remove it. WDYT @RaisinTen ?
| sh(script: "git clone https://github.com/emscripten-core/emsdk.git", returnStatus: true) | ||
| sh(script: "(cd emsdk && ./emsdk install latest)", returnStatus: true) | ||
| sh(script: "(cd emsdk && ./emsdk activate latest)", returnStatus: true) |
There was a problem hiding this comment.
Does this take a small enough amount of time that we can do it every time?
|
I've heard from @mhdawson that we don't use pipelines a lot, so we worked on creating this job instead - https://ci.nodejs.org/view/All/job/node-test-postject. See #3126 for more info on that. Closing this in favor of that job. |
Fixes: nodejs/postject#62
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @nodejs/single-executable