Repository navigation
Conversation
richardlau
approved these changes
Nov 11, 2019
Member
|
This has addressed the |
Member
|
Temporarily marked |
Member
|
|
richardlau
approved these changes
Nov 12, 2019
Member
|
The rebuilt Python 3 looks good (nodejs/node#30152 (comment)) -- the V8 CI on |
sam-github
approved these changes
Nov 12, 2019
sam-github
added a commit
that referenced
this pull request
Nov 12, 2019
So that python3 builds can include these features. PR-URL: #2044
Contributor
|
Landed in 602de5f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2042 (comment)
Fixes issue 1 in nodejs/node#30152
This has been run on test-osuosl-centos7-ppc64--le-2 and it worked