Repository navigation
lint job doesn't show tap result #720
Description
Maybe I'm doing something wrong, but I can't figure out how to get the lint errors...
e.g. https://ci.nodejs.org/job/node-test-linter/9042/console
+ gmake lint-ci
Running JS linter...
./node tools/jslint.js -j 2 -f tap -o test-eslint.tap \
benchmark doc lib test tools
gmake: *** [Makefile:870: jslint-ci] Error 1
Build step 'Execute shell' marked build as failure
Run condition [Always] enabling perform for step [[Execute a set of scripts]]
[PostBuildScript] - Execution post build scripts.
[PostBuildScript] Build is not success : do not execute script
Run condition [Always] enabling perform for step [[Execute a set of scripts]]
[PostBuildScript] - Execution post build scripts.
[node-test-linter] $ /bin/sh -xe /tmp/hudson6596229026728241521.sh
+ set +x
Notifying upstream projects of job completion
Finished: FAILURE
Sorry to fast fire issues today.
Activity
gibfahn commentedon May 13, 2017
You're right, we're passing the output to a TAP file, but not actually running the TAP parser on it. I tried enabling it, but the TAP plugin fails to parse it as it isn't valid TAP.
The problem with the generated TAP output is that it's actually multiple TAP files concatenated together, so there are multiple TAP headers.
In the short term you can view the file directly (assuming you have the permissions) by going to the workspace.
gibfahn commentedon May 13, 2017
Looks like we can definitely blame @jbergstroem for this 😜
@mscdex nodejs/node#5638 (comment)
@jbergstroem nodejs/node#5638 (comment)
gibfahn commentedon May 13, 2017
So basically we need to update tools/jslint.js to remove all but the first instance of
TAP version 13, I think that should work.refack commentedon May 13, 2017
I'm on it.
P.S. the
workspacewill only show that last run, right?gibfahn commentedon May 13, 2017
Yes, it's overwritten every time.
gibfahn commentedon May 14, 2017
I lied, the plan can't be repeated, I tested it and it still breaks the TAP parsing plugin. The easiest solution is to use Subtests that Jenkins can understand (see the plugin docs):
I've confirmed that this works in a test job:
refack commentedon May 14, 2017
I started writing the PR... ✍️
gibfahn commentedon Oct 7, 2017
I changed
to
, so if the test fails you'll get the test output catted to the console.
It's not the best solution, but I think it solves the problem in the immediate term.
gibfahn commentedon Oct 8, 2017
New solution (to hopefully avoid #906) and make it easier to see what's going on:
Filters out the passing tests, the
TAP version 13headers, and the1..10lines.refack commentedon Oct 8, 2017
grep -v -P "^(ok|1\.\.|TAP|$)" test-eslint.tapgibfahn commentedon Oct 8, 2017
Updated comment above, the script got a bit more complicated because:
/bin/bashdoesn't existseddoesn't support\sfor whitespace.test-rackspace-freebsd10-x64-1which hasgsed, the other istest-joyent-freebsd10-x64-2which doesn't.So at the moment on the
joyentbox it doesn't trim whitespace, and on the otherrackspacebox it does. If we could:sed '/^\s*$/d'is (and test it on thejoyentbox)That would improve the situation.
At the moment the
freebsdbox trims blank lines, but thejoyentone doesn't. It's better than before, but not ideal.[-]lint job doesn't show tap resault[/-][+]lint job doesn't show tap result[/+]gibfahn commentedon Oct 22, 2017
This is done for now, better solutions always appreciated.