Skip to content

release/index.json for v6.8.1 has invalid modules value #519

Closed

Description

@phillipj

As reported in nodejs/nodejs.org#969, the v6.8.1 release has modules: null in https://nodejs.org/download/release/index.json.

I assume the modules value originates from fetchModVersion() in dist-indexer.js. I've manually tested the regexes in that method against node_version.h and node.h, where the former seems to match perfectly fine, meaning it should not have resolved the modules value to null.

Any thoughts on how this might have happened? Could we execute dist-indexer.js manually to see if it was a temporary glitch, and the correct modules value gets resolved now?

Activity

  1. phillipj commented on Oct 15, 2016

    @phillipj
    MemberAuthor

    Just noticed v6.8.1 also has zlib: null

  2. targos commented on Oct 15, 2016

    @targos
    Member

    It's also missing the npm property

  3. targos commented on Oct 15, 2016

    @targos
    Member

    And uv is an empty string

  4. phillipj commented on Oct 16, 2016

    @phillipj
    MemberAuthor

    /cc @nodejs/release

  5. MylesBorins commented on Oct 16, 2016

    @MylesBorins
    Contributor

    /cc @nodejs/ctc

  6. jbergstroem commented on Oct 17, 2016

    @jbergstroem
    Member

    The likely cause is us switching www hosts (was running out of disk space). Not sure exactly what.

    1. We moved the dist indexer to a new place: https://github.com/nodejs/nodejs-dist-indexer
    2. The dist indexer at our old www host is pretty much identical to currently deployed at new place (just making sure that no un-committed code was running)
    3. The scripts look like they are invoked the same way
  7. rvagg commented on Oct 17, 2016

    @rvagg
    Member

    I've run it again and it's updated. This can happen if the tag is not pushed to the public repo before being promoted. @evanlucas I think you did 6.8.1, do you recall if this happened?

  8. evanlucas commented on Oct 17, 2016

    @evanlucas

    Looking back, I may not have pushed the tag when I promoted

  9. rvagg commented on Oct 18, 2016

    @rvagg
    Member

    pretty sure nodejs/node#9142 will solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions