macOS pkg release build failures #2850

Activity

1. targos

   added

   incident

   ci-release

   on Jan 18, 2022
2. targos commented on Jan 18, 2022

   

   targos

   on Jan 18, 2022

   MemberAuthor

   More actions

   @nodejs/jenkins-release-admins
3. rvagg commented on Jan 18, 2022

   

   rvagg

   on Jan 18, 2022

   Member

   More actions

   https://github.com/nodejs/node/blob/6beee312a47165f8dd65fe802b6280310e6caede/Makefile#L833

   that line will need fixing, npm's package.json has a new "templateOSS" section with a "version": "2.4.3" in it, so NPMVERSION is coming out as:

   8.3.1
       "version": "2.4.3"
   

   rather than just 8.3.1 as it would previously have done.

   hence:

   07:10:54 pkgbuild --version v8.3.1     "version": "2.4.3" \
   07:10:54 		--identifier org.nodejs.npm.pkg \
   07:10:54 		--root out/macos/dist/npm \
   07:10:54 		--scripts ./tools/macos-installer/pkgbuild/npm/scripts \
   07:10:54 			out/macos/pkgs/npm-v8.3.1     "version": "2.4.3".pkg
   

   in the build logs
4. targos

   added a commit that references this issue on Jan 18, 2022

   build: fix npm version detection

   ...

   a8f0fee
5. targos commented on Jan 18, 2022

   

   targos

   on Jan 18, 2022

   MemberAuthor

   More actions

   Proposed fix: nodejs/node#41575
6. targos

   closed this as completedin 331b906on Jan 18, 2022
7. targos

   added a commit that references this issue on Jan 18, 2022

   build: fix npm version detection

   ...

   4958c80
8. targos commented on Jan 18, 2022

   

   targos

   on Jan 18, 2022

   MemberAuthor

   More actions

   Thanks for investigating @rvagg !
9. danielleadams

   added a commit that references this issue on Feb 1, 2022

   build: fix npm version detection

   ...

   5c1dc5f
10. MayaLekova

    added a commit that references this issue on May 22, 2026

    build: fix npm version detection

    ...

    331b906