Repository navigation
Enable GitHub Codespaces for Node.js #808
Description
Recently, the OpenJS Foundation pivoted, enabling Codespaces Billing on the Webpack organisation (openjs-foundation/cross-project-council#1009). I'd like the same to be done on the Node.js organisation.
I can see clear benefits in productivity as we could access the large Codepsaces Runners and build Node.js on the cloud if needed. Also, it would bring benefits where collaborators are far from their development machines but could still contribute.
At least I'm already using it daily for the Website Team, but paying from my pocket.
I don't know if this needs TSC consensus. cc @nodejs/tsc
Activity
ovflowd commentedon Jul 6, 2023
cc @mhdawson
targos commentedon Jul 6, 2023
SGTM as long as we have the budget for it and it is not abused.
ovflowd commentedon Jul 6, 2023
We should probably enable only specific repositories. Afaik, this is configurable. And we can keep track of the billing to see who users are potentially abusing the system.
mcollina commentedon Jul 6, 2023
sgtm
ovflowd commentedon Jul 10, 2023
Do we need to add this to the TSC agenda, or is this sgtm enough to the point of simply requesting the Foundation to do it?
Or are there any further details to be done?
Trott commentedon Jul 11, 2023
Probably a good idea to add it to a TSC agenda for awareness purposes, but also I'd consider open-for-5-days-with-2-approvals-from-TSC-members sufficient to make the request.
And it SGTM too, so that's three TSC members.
BridgeAR commentedon Jul 11, 2023
SGTM
ovflowd commentedon Aug 3, 2023
@Trott was there any review? Or any update? Or does
tsc-reviewonly means, awaiting for TSC members to approve?RaisinTen commentedon Aug 3, 2023
tsc-reviewwas removed in nodejs/node#26506. Any chance you wanted to apply the tsc-agenda label, so that this issue gets mentioned in the next meeting for awareness purposes? FWIW, this issue was very briefly mentioned in https://www.youtube.com/live/ikPN11Qksl8?feature=share&t=373 but no review happened on the meeting.ovflowd commentedon Aug 3, 2023
Hmm, yeah I guess tsc-agenda then?
mhdawson commentedon Aug 3, 2023
@ovflowd can you confirm that if we enable, it will only be able to be used up to the $ that the Foundation has provided? If so then I'm STGM as well.
ovflowd commentedon Aug 3, 2023
Hey @mhdawson according to this https://github.com/openjs-foundation/cross-project-council/blob/main/project-resources/REQUESTING_GITHUB_RESOURCES.md, yes.
(And I double-checked with Ben). He would need to be added as Billing Manager (as stated in the doc) and then we can put limits, limit how many codespaces each user can create, we can even limit which repositories can have codespaces (billed to the Node.js org) and even limit who can have access to it (if we want to make it opt-in)
mhdawson commentedon Aug 3, 2023
LGTM
ovflowd commentedon Aug 7, 2023
@mhdawson let me know once there's an update on the next TSC meeting, so depending of the outcome I'd be able to forward this to the CPC :)
mhdawson commentedon Aug 14, 2023
@ovflowd its on the agenda for the TSC meeting this week. I'll let you know the outcome of any discussion.
mcollina commentedon Aug 16, 2023
SGTM, approved in today's TSC meeting
ovflowd commentedon Aug 16, 2023
Opened a PR on the Foundation's CPC repository: openjs-foundation/cross-project-council#1149