Repository navigation
Add SLACK_WEBHOOK secret to nodejs/node #551
Description
Add SLACK_WEBHOOK secret which is a webhook URL to the OpenJS Foundation #nodejs-dev Slack channel. This allows us to send selective notifications to the channel via Actions, such as notifying folks when someone force pushes.
Activity
mmarchini commentedon Sep 9, 2020
cc @nodejs/tsc @nodejs/community-committee reminder we need two +1s from each committee
mhdawson commentedon Sep 9, 2020
+1
Trott commentedon Sep 10, 2020
+1
mmarchini commentedon Sep 13, 2020
Need one more from @nodejs/community-committee
mmarchini commentedon Sep 22, 2020
@nodejs/community-committee need one more +1
Trott commentedon Sep 24, 2020
I forget where, but I believe we documented that for people who are on both committees, their vote can count for one committee or the other. Did we change that and now Michael Dawson has the double-value vote? I mean, not that we need to raise the obstacles to approval higher....
Trott commentedon Sep 24, 2020
I can't find it anywhere, so I think we should go with what you (@mmarchini) have been going with. If someone wants to make it harder to approve things, they an open a pull request to change the GitHub policy doc in this repo. I don't think anyone is going to advocate for that. Certainly not me.
mmarchini commentedon Sep 24, 2020
I've been counting each persons vote as one vote, so if they are on two committees they vote counts towards the committee with least votes so far. It doesn't change the fact that we have three TSC votes (you, Shelley and Michaël) and one CommComm vote (Michael). We still need one more from CommComm.
mmarchini commentedon Sep 24, 2020
(we don't require 4 votes, we require two from each committee)
Edit: fwiw I very much dislike our current requirements.
mmarchini commentedon Sep 24, 2020
added to commcomm agenda for awareness
Trott commentedon Sep 24, 2020
Ah, I didn't realize that we count the GitHub reactions too.
If nothing else, our current process could use some clarifying, at least for me.
mmarchini commentedon Sep 24, 2020
If we don't, I've passed some apps and secrets without proper approvals 😅
bnb commentedon Oct 1, 2020
+1
designMoreWeb commentedon Oct 1, 2020
+1
joesepi commentedon Oct 1, 2020
+1
mmarchini commentedon Jan 5, 2021
Secret added and PR landed.