Building addons with cmake #381

Activity

1. mhdawson

   added this to the Milestone 11 milestone on Aug 29, 2019
2. mhdawson commented on Sep 16, 2019

   

   mhdawson

   on Sep 16, 2019

   MemberAuthor

   More actions

   Nicola, we should look at existing solutions like cmake-js and see if they need any updates to support node-addon-api.

   Jim, the work he did for pre-build was for cmake-js.

   Nicola, maybe we can move some of what Jim did for pre-build to cmake-js so that all dependencies can leverage that.

   Jim, cmake-js is pretty generic, did not have to do much, only document what you needed there.

   Nicola then it might just be a matter of documentation.

   Jim will:

   • review issue and let us know what he thinks we we should do
   • add links to the doc he created to node-gyp Python 3 support node-addon-api#445
3. gengjiawen commented on Sep 19, 2019

   

   gengjiawen

   on Sep 19, 2019

   Last edited by gengjiawen

   Member

   More actions

   node-gyp already support generate cmake config. I have used it in Clion, works pretty well (code autocomplete and debug).
4. jschlight commented on Sep 27, 2019

   

   jschlight

   on Sep 27, 2019

   Last edited by jschlight

   Collaborator

   More actions

   I've added a comment here about building N-API addons using CMake.js: nodejs/node-addon-api#445 (comment)
5. jschlight commented on Sep 30, 2019

   

   jschlight

   on Sep 30, 2019

   Last edited by jschlight

   Collaborator

   More actions

   During today's call we discussed the behavior of CMake.js when the underlying CMake executable is not installed. Here's what I found:

   spare:~ jim$ npm install -g cmake-js
   /Users/jim/.nvm/versions/node/v10.16.3/bin/cmake-js -> /Users/jim/.nvm/versions/node/v10.16.3/lib/node_modules/cmake-js/bin/cmake-js
   + cmake-js@6.0.0
   added 140 packages from 108 contributors in 8.486s
   spare:~ jim$ cmake
   -bash: cmake: command not found
   spare:~ jim$ cmake-js
   [ '/Users/jim/.nvm/versions/node/v10.16.3/bin/node',
     '/Users/jim/.nvm/versions/node/v10.16.3/bin/cmake-js' ]
   info TOOL Using Unix Makefiles generator.
   ERR! OMG CMake executable is not found. Please use your system's package manager to install it, or you can get installers from there: http://cmake.org.
   spare:~ jim$ 
   

   CMake.js displays a message instructing the user to install the CMake executable if it is not found.

   👍React with 👍1Reacted by Nicola Del Gobbo
6. mhdawson commented on Oct 1, 2019

   

   mhdawson

   on Oct 1, 2019

   MemberAuthor

   More actions

   @jschlight thanks for checking that out. Great to see that it shows a good message.
7. jschlight commented on Oct 24, 2019

   

   jschlight

   on Oct 24, 2019

   Collaborator

   More actions

   The PR merge should have closed this issue? But maybe the automatic close does not work between repos?
8. jschlight

   closed this as completedon Oct 24, 2019