Skip to content

Use ref/unref terminology instead of addref/release #188

Closed
Closed
Use ref/unref terminology instead of addref/release#188
Assignees
boingoing

Description

@jasongin
jasongin
opened on Mar 22, 2017

Consider renaming:

  • napi_reference_addref()
  • napi_reference_release()

To:

  • napi_reference_ref()
  • napi_reference_unref()

To be consistent with the "Ref/Unref" terminology used throughout Node.js.

See nodejs/node#11975 (comment)

Activity

  1. aruneshchandra
    assigned
    boingoing
    on Mar 22, 2017

  2. boingoing commented on Mar 23, 2017

    @boingoing
    boingoing
    on Mar 23, 2017

    Fixed by #193

  3. boingoing
    closed this as completedon Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions