Create GitHub team for reviewing src (C++) changes #1237

Activity

1. targos commented on Jun 2, 2022

   

   targos

   on Jun 2, 2022

   Member

   More actions

   +1

   (I was going to create this in the core repo but I don't know how to bypass the templates there.)

   https://github.com/nodejs/node/issues/new
2. tniessen commented on Jun 9, 2022

   

   tniessen

   on Jun 9, 2022

   Last edited by tniessen

   MemberAuthor

   More actions

   This has been open for more than a week with a few +1s and no objections, so I created the team as proposed.

   @nodejs/cpp-reviewers You have been added to this team because at least one of the following is true, based on the commit history from the last 365 days:

   1. You reviewed at least 5 commits, and at least 50 % of all commits that you reviewed modified files in src/.

      join -t $'\t' -1 2 -2 2 <(git log --format='format:%b' --since '1 year ago' | grep '^Reviewed-By: ' | tr -d '\r' | sort | uniq -c | awk '{ f=$1; $1=""; print f"\t"$0; }') <(git log --format='format:%b' --since '1 year ago' -- src | grep '^Reviewed-By: ' | tr -d '\r' | sort | uniq -c | awk '{ f=$1; $1=""; print f"\t"$0; }') | awk  -F'\t' 'BEGIN {OFS = FS} { r=100*$3/$2 ; if ($2 >= 5 && r > 50) { print $1 } }'

   2. You authored at least 15 commits that modified files in src/.

      git log --format='format:%aN' --since '1 year ago' -- src | sort | uniq -c | sort -nr | awk '{ if ($1 >= 15) print $0 }'

   3. You are among the 5 collaborators who reviewed the most commits that modified files in src/.

      git log --format='format:%b' --since '1 year ago' -- src | grep '^Reviewed-By: ' | tr -d '\r' | sort | uniq -c | sort -nr | head -5

   Please feel free to remove yourself from the team if you do not wish to be pinged for reviews.

   Everyone else, please feel free to add yourself to the team if you do wish to be pinged for reviews.

   🚀React with 🚀1Reacted by Filip Skokan
3. tniessen

   closed this as completedon Jun 9, 2022