Repository navigation
Before running the sketch, check if all references are valid #17
Description
Currently resolving references happens at runtime, which means sketches like this only fail 50% of the time:
root:
- This line is fine
- This line contains an invalid {{ reference }}
To avoid these errors happening at runtime I suggest creating a validation step in parsePhraseBook that checks if all references in the script are valid.
Activity
kunal-mohta commentedon Feb 19, 2018
This would require another loop to be run after the already running loop, because once the first loop is completed then only we can determine whether a reference is defined or not.
If I am going in the right direction, can I try this?
fdb commentedon Feb 20, 2018
Actually we just need to check all references we encounter during parsing. We don't need to run the code "normally" at all.
Give it a try if you want!
kunal-mohta commentedon Feb 20, 2018
Okay, I will give it a try.
kunal-mohta commentedon Feb 21, 2018
Wait, I don't think I got this right.
Say for example, we have
How will we know at line
(*)and(**)thatreference1andreference2are defined after(***)or not, without running the code "normally"stebanos commentedon Feb 21, 2018
kunal-mohta commentedon Feb 21, 2018
Oh! Okay. I thought you were planning to implement this inside
parsePharsebook()function.kunal-mohta commentedon Feb 21, 2018
Should the check be included here
fdb commentedon Feb 22, 2018
No idea. @stebanos ?
stebanos commentedon Feb 22, 2018
No, it should be checked after everything is parsed, before returning the phraseBook, so yes, inside the parsePhrasebook function, but at the end. Because it is only at this point we know for sure what all the phrases and references are.
kunal-mohta commentedon Feb 22, 2018
Won't that mean rewriting the code that extracts the references from
{{ ... }}, that already has been written?stebanos commentedon Feb 22, 2018
No, the check needs to perform a similar action as what happens in the Interpreter class. For each phrase, the Parser class returns a tree of nodes of a certain type, some of these nodes are of type NODE_KEY, it's these ones that need to be checked against the whole of the phraseBook. Since these nodes are "buried" within the tree, the tree needs to be traversed, like what happens in the visit(node) function.