Skip to content

Installation path is incorrect #910

Closed

Description

@mprync

Calling "make install" now installs json.hpp to "nlohmann/src/json.hpp".

No sure if this was intentional.

The issue is from the latest PR change here.

Activity

  1. changed the title [-]Installation path incorrect[/-] [+]Installation path is incorrect[/+] on Jan 11, 2018
  2. nlohmann commented on Jan 13, 2018

    @nlohmann
    Owner

    I am not CMake expert - what should be the value in your opinion?

  3. theodelrieu commented on Jan 13, 2018

    @theodelrieu
    Contributor

    Oops I haven't tried that, I'll take a look this afternoon

  4. nlohmann commented on Jan 14, 2018

    @nlohmann
    Owner

    Fixed with merging #911.

    @InFaMoUsZero Could you please check if this fixes the issue for you?

  5. added
    solution: proposed fixa fix for the issue has been proposed and waits for confirmation
    and removed on Jan 14, 2018
  6. added this to the Release 3.1.0 milestone on Jan 14, 2018
  7. self-assigned this
    on Jan 14, 2018
  8. mprync commented on Jan 14, 2018

    @mprync
    Author

    @nlohmann Sure, I can test this on Tuesday and hopefully get this closed off.

  9. mprync commented on Jan 16, 2018

    @mprync
    Author

    @nlohmann I can confirm this has now fixed the issue.

  10. nlohmann commented on Jan 16, 2018

    @nlohmann
    Owner

    Thanks for checking back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

solution: proposed fixa fix for the issue has been proposed and waits for confirmation

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions