Conversion from valarray<double> to json fails to build #702

Activity

1. theodelrieu commented on Aug 21, 2017

   

   theodelrieu

   on Aug 21, 2017

   Contributor

   More actions

   Oops, this is due to the has_iterator traits that check for a iterator type alias, which valarray doesn't provide. Sorry about that.

   namespace nlohmann
   {
   template <typename T>
   struct adl_serializer<std::valarray<T>>
   {
     static void to_json(json &j, std::valarray<T> const &v)
     {
       detail::external_constructor<detail::value_t::array>::construct(j, v);
     }
   
     static void from_json(json const &j, std::valarray<T> &v)
     {
       // checks omitted, not the best implem, never played with valarray myself
       auto arr = j.get<std::vector<T>>();
       v = std::valarray<T>(arr.data(), arr.size());
     }
   };
   }

   As for the bug fix release, I don't know what @nlohmann thinks about it.
2. nlohmann

   added

   confirmed

   kind: bug

   on Aug 21, 2017
3. nlohmann commented on Aug 21, 2017

   

   nlohmann

   on Aug 21, 2017

   Owner

   More actions

   We need to fix this and add std::valarray support for the 3.x.x release. I did not plan to create a bug fix release for this.
4. nlohmann

   self-assigned this

   on Aug 22, 2017
5. nlohmann

   added this to the Release 3.0.0 milestone on Aug 22, 2017
6. nlohmann

   added a commit that references this issue on Aug 22, 2017

   🐛 re-added support for std::valarray #702

   9fd031b
7. nlohmann

   added

   solution: proposed fixa fix for the issue has been proposed and waits for confirmationa fix for the issue has been proposed and waits for confirmation

   on Aug 22, 2017
8. nlohmann commented on Aug 23, 2017

   

   nlohmann

   on Aug 23, 2017

   Owner

   More actions

   Fixed with 9fd031b.
9. nlohmann

   closed this as completedon Aug 23, 2017