Repository navigation
a bug of inheritance ? #608
Description
I did a test of inheriting from class nlohmann::json, and it's a little difference if I directly use nlohmann::json.
#include "json.hpp"
using json = nlohmann::json;
class JSON : public json {};
int main(int argc, char* argv[])
{
JSON j;
JSON j1;
j1["k"] = "v";
j["o"] = j1;
std::cout << j.dump() << std::endl;
return 0;
}the result: {"o":["v"]}
#include "json.hpp"
using json = nlohmann::json;
//class JSON : public json {};
int main(int argc, char* argv[])
{
json j;
json j1;
j1["k"] = "v";
j["o"] = j1;
std::cout << j.dump() << std::endl;
return 0;
}the result: {"o":{"k":"v"}}
"k" is lost in inheritance condition
Activity
nlohmann commentedon Jun 6, 2017
It seems as if
is_compatible_array_type<BasicJsonType, CompatibleArrayType>::valueholds true in the inheritance case whenj["o"] = j1is called:j1is treated as if it was an array, sostatic void construct(BasicJsonType& j, const CompatibleArrayType& arr)is called on the rangej1.begin()/j1.end(). Asj1is a string, this range returns exactly 1 item. For this reason, the result is["v"].I am not sure how to fix this right now. Maybe @theodelrieu has an idea. I guess we all just forgot about the case of inheriting from
basic_json.theodelrieu commentedon Aug 14, 2017
Sorry for the veeery late reply, just found about this issue.
I will look into it!
stale commentedon Oct 25, 2017
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.