Skip to content

C++17's ambiguous conversion #586

Closed
Closed
C++17's ambiguous conversion#586
Assignees
nlohmann
Labels
confirmedkind: bugsolution: proposed fixa fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.0.0

Description

@Krysme
Krysme
opened on May 16, 2017

In c++ 17, std::string_view can be converted to std::string implicitly which leads to a problem that in c++17 mode , a json object cannot be assigned to a string due to ambiguous assigning conversion path ( json --> string and json --> string_view --> string).

In gcc 7.1 such code produces a compilation error width -std=c++1z.

code:

#include "json.hpp"
#include <string>


int main()
{

    nlohmann::json j;
    j = "12345";
    std::string s;
    s = j;

    return 0;
}

So, is it possible to remove the conversion to string specifically in c++17 mode to let the compiler select the json--> string_view --> string path ?

Activity

  1. nlohmann commented on May 16, 2017

    @nlohmann
    nlohmann
    on May 16, 2017
    Owner

    This seems related to #464.

  2. nlohmann
    added
    kind: bug
    confirmed
    on May 16, 2017

  3. nlohmann commented on May 16, 2017

    @nlohmann
    nlohmann
    on May 16, 2017
    Owner

    Checked with the latest GCC trunk version:

    In file included from /Users/niels/Documents/projects/gcc/include/c++/8.0.0/string:52:0,
                 from /Users/niels/Documents/projects/gcc/include/c++/8.0.0/stdexcept:39,
                 from /Users/niels/Documents/projects/gcc/include/c++/8.0.0/array:39,
                 from src/json.hpp:33,
                 from c17.cpp:1:
/Users/niels/Documents/projects/gcc/include/c++/8.0.0/bits/basic_string.h: In instantiation of ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_If_sv<_Tp, std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&> std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator=(_Tp) [with _Tp = nlohmann::basic_json<>; _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::_If_sv<_Tp, std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&> = std::__cxx11::basic_string<char>&]’:
c17.cpp:11:9:   required from here
/Users/niels/Documents/projects/gcc/include/c++/8.0.0/bits/basic_string.h:764:28: error: call of overloaded ‘assign(nlohmann::basic_json<>&)’ is ambiguous
  { return this->assign(__sv); }
                            ^
/Users/niels/Documents/projects/gcc/include/c++/8.0.0/bits/basic_string.h:1313:7: note: candidate: ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::assign(const std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’
       assign(const basic_string& __str)
       ^~~~~~
/Users/niels/Documents/projects/gcc/include/c++/8.0.0/bits/basic_string.h:1329:7: note: candidate: ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::assign(std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&&) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’
       assign(basic_string&& __str)
       ^~~~~~
/Users/niels/Documents/projects/gcc/include/c++/8.0.0/bits/basic_string.h:1440:7: note: candidate: ‘std::__cxx11::basic_string<_CharT, _Traits, _Alloc>& std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::assign(std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::__sv_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::__sv_type = std::basic_string_view<char>]’
       assign(__sv_type __sv)
       ^~~~~~

  4. Krysme commented on May 16, 2017

    @Krysme
    Krysme
    on May 16, 2017
    Author

    Thanks for the replying.This error message you posted is exactly what I had.

  5. nlohmann commented on May 20, 2017

    @nlohmann
    nlohmann
    on May 20, 2017
    Owner

    This fixes the issue:

    diff --git a/src/json.hpp b/src/json.hpp
index 85d559d7..7bfb7359 100644
--- a/src/json.hpp
+++ b/src/json.hpp
@@ -3742,7 +3742,7 @@ class basic_json
 #ifndef _MSC_VER  // fix for issue #167 operator<< ambiguity under VS2015
                    and not std::is_same<ValueType, std::initializer_list<typename string_t::value_type>>::value
 #endif
-#if defined(_MSC_VER) && _MSC_VER >1900 && defined(_HAS_CXX17) && _HAS_CXX17 == 1 // fix for issue #464
+#if (defined(__cplusplus) && __cplusplus == 201703L) || (defined(_MSC_VER) && _MSC_VER >1900 && defined(_HAS_CXX17) && _HAS_CXX17 == 1) // fix for issue #464
                    and not std::is_same<ValueType, typename std::string_view>::value
 #endif
                    , int >::type = 0 >
  6. nlohmann
    added a commit that references this issue on May 20, 2017

    🐛 fix for #586

    99cb095
  7. nlohmann
    self-assigned this
    on May 20, 2017
  8. nlohmann
    added this to the Release 3.0.0 milestone on May 20, 2017
  9. nlohmann
    added
    solution: proposed fixa fix for the issue has been proposed and waits for confirmation
    on May 20, 2017

  10. Krysme commented on May 20, 2017

    @Krysme
    Krysme
    on May 20, 2017
    Author

    thanks for the fix.
    btw is it better to change __cplusplus == 201703L to __cplusplus >= 201703L for future version of c++?

  11. nlohmann commented on May 20, 2017

    @nlohmann
    nlohmann
    on May 20, 2017
    Owner

    Very good point. I shall fix this.

  12. nlohmann
    added a commit that references this issue on May 20, 2017

    🐛 adjusting fix for future versions #586

    9ddc69f
  13. nlohmann
    closed this as completedon May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

confirmedkind: bugsolution: proposed fixa fix for the issue has been proposed and waits for confirmation

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions