Cannot get float pointer for value stored as 0 #484

Activity

1. koemeet

   changed the title [-]Cannot get float pointer for int storage type[/-] [+]Cannot get float pointer for value stored as `0`[/+] on Mar 6, 2017
2. koemeet commented on Mar 7, 2017

   

   koemeet

   on Mar 7, 2017

   ContributorAuthor

   More actions

   I am using the following as a temporary solution:

   /// get a pointer to the value (floating-point number)
   number_float_t* get_impl_ptr(number_float_t* /*unused*/) noexcept
   {
   	if (is_number_integer())
   	{
   		m_type = value_t::number_float;
   		m_value.number_float = static_cast<float>(m_value.number_integer);
   	}
   
       return is_number_float() ? &m_value.number_float : nullptr;
   }
3. nlohmann

   added

   kind: question

   state: help neededthe issue needs help to proceedthe issue needs help to proceed

   on Mar 7, 2017
4. nlohmann commented on Mar 7, 2017

   

   nlohmann

   on Mar 7, 2017

   Owner

   More actions

   I understand your problem, but don't know a solution either. Your fix is pragmatic, but I think it's counter-intuitive to change a type with a getter. Maybe someone else has a better idea?
5. gregmarr commented on Mar 7, 2017

   

   gregmarr

   on Mar 7, 2017

   Contributor

   More actions

   I'd say this would be a reasonable thing for the library client to do, but not for the library itself to do. If the client knows that it needs a float there, then it's perfectly reasonable for the client to make it a float.

   👍React with 👍2Reacted by TurpentineDistillery and Niels Lohmann
6. nlohmann commented on Mar 11, 2017

   

   nlohmann

   on Mar 11, 2017

   Owner

   More actions

   I think changing the library in this regard is not helpful.
7. nlohmann

   closed this as completedon Mar 11, 2017
8. nlohmann

   added

   solution: wontfixthe issue will not be fixed (either it is impossible or deemed out of scope)the issue will not be fixed (either it is impossible or deemed out of scope)

   and removed

   state: help neededthe issue needs help to proceedthe issue needs help to proceed

   on Mar 11, 2017