Skip to content

Support for integers not from the range [-(2**53)+1, (2**53)-1] in parser #291

Closed

Description

@antonovvk

Currently the test below fails:

TEST(WTF, BigInteger)  {
    nlohmann::json val = -3383556239975101330LL;
    val = nlohmann::json::parse(val.dump());
    EXPECT_EQ(-3383556239975101330, val.get<int64_t>());
}

And this is the internal inconsistency.
As far as I know, RFC does not require JSON integers to be in any range.
I think that internal consistency is more important than possible non-interoperability with third-party JSON parsers.

Activity

  1. antonovvk commented on Aug 11, 2016

    @antonovvk
    Author

    Sorry, I was using v1.1.0 and haven't noticed that this is fixed in newer versions.
    Thank you for the great lib!

  2. nlohmann commented on Aug 11, 2016

    @nlohmann
    Owner

    No problem - when I saw the title, I though "Man, didn't we already fix this?" ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    solution: invalidthe issue is not related to the library

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions