Member detector is not portable #166

Activity

1. glenfe

   closed this as completedon Dec 30, 2015
2. glenfe

   reopened this on Dec 30, 2015
3. nlohmann commented on Jan 1, 2016

   

   nlohmann

   on Jan 1, 2016

   Owner

   More actions

   Doesn't the C++ standard guarantee sizeof(char) == 1 and an int to have a width of at least 16 bits?
4. glenfe commented on Jan 1, 2016

   

   glenfe

   on Jan 1, 2016

   Author

   More actions

   Yes? A C++ implementation can make sizeof(char) == sizeof(int) == 1 where CHAR_BIT is 16.
5. nlohmann commented on Jan 1, 2016

   

   nlohmann

   on Jan 1, 2016

   Owner

   More actions

   I see... (Even though this would be really odd...)
6. glenfe commented on Jan 1, 2016

   

   glenfe

   on Jan 1, 2016

   Author

   More actions

   Here's one possible fix:

   template<typename C> static char (&test(...))[2];
   

   Also, consider changing the next line to:

   static constexpr bool value = sizeof(test<T>(0)) == 1;
   
7. nlohmann commented on Jan 1, 2016

   

   nlohmann

   on Jan 1, 2016

   Owner

   More actions

   That's way more elegant. Thanks a lot for nitpicking on this. And Happy New Year!
8. nlohmann

   added a commit that references this issue on Jan 1, 2016

   fix for #166

   9b07504
9. nlohmann

   added

   improvement

   on Jan 1, 2016
10. nlohmann

    added this to the Release 1.0.1This milestone has been deleted milestone on Jan 1, 2016
11. nlohmann

    self-assigned this

    on Jan 1, 2016
12. nlohmann

    closed this as completedon Jan 1, 2016