Repository navigation
chore(deps): add rector - #2366
Merged
Merged
Conversation
Antreesy
force-pushed
the
chore/rector
branch
from
October 29, 2026 13:21
0bad830 to
ff0ab59
Compare
Antreesy
marked this pull request as ready for review
October 29, 2026 13:22
nickvergessen
approved these changes
Oct 30, 2026
Add rector with the PHP 8.3 and Nextcloud 35 sets in its own composer-bin namespace. rector/rector is pinned to 2.7, because nextcloud/rector 0.5.2 is not compatible with rector 2.8. ReplaceInjectedMethodCallRector is skipped, because it rewrites IConfig app value calls to the untyped IAppConfig::getValue() and setValue(). Those exist only in OC\AppConfig. OCP\IAppConfig has only typed getters and setters, so the type must be picked per call site. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Generated with `composer rector:fix`. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
chore/rector
branch
from
October 30, 2026 13:08
ff0ab59 to
0690ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)