Repository navigation
Conversation
…em, even when the diagnosis is held, so they can answer while still active Questions in the triage comment went unanswered because medium- and low-confidence runs are held, and nothing flagged the reporter even when one posted. The run now records them as a separate bugzilla.request_info action, which hackbot-api always applies and which needinfos the bug's creator in the same PUT. Fixes mozilla#7181
msujaws
force-pushed
the
frontend-triage-needinfo-reporter
branch
from
October 26, 2026 20:54
dda1bbd to
bb3e3c3
Compare
crythms
requested changes
Oct 27, 2026
crythms
left a comment
crythms
left a comment
Member
There was a problem hiding this comment.
@msujaws looks great!
A few small changes that I think should be made
1. The needinfo can replace someone else's needinfo.
In RequestInfoHandler, the flag is sent without "new": True. When that's missing, Bugzilla reuses the needinfo already on the bug instead of adding one.
- If the bug already has one needinfo (say, on a developer), it gets switched to the reporter. The developer's request just disappears.
- If the bug has two or more, Bugzilla rejects the whole update, so the question doesn't get posted either.
Potential Fix: add "new": True to the flag. (This is in BMO's extract_flags in Bugzilla/WebService/Util.pm.)
- Questions get posted on bugs the agent decided not to triage.
record_reporter_questiondoesn't checkactionable. So a run that skips a bug (enhancement, meta, intermittent failure) can still post a question and needinfo the reporter, with nobody reviewing it. For intermittent failures, that reporter is often a bot account.
Potential Fix: return early when result.actionable is False, and mention it in the prompt.
| "bugzilla.add_comment": AddCommentHandler(), | ||
| "bugzilla.add_attachment": AddAttachmentHandler(), | ||
| "bugzilla.create_bug": CreateBugHandler(), | ||
| "bugzilla.request_info": RequestInfoHandler(), |
Member
There was a problem hiding this comment.
We could use bugzilla.update_bug to add a needinfo. Is there a reason why that would not work here?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions in a frontend-triage comment only reach the reporter if they happen to reread the bug, and medium- and low-confidence runs, the ones most likely to ask, are held, so their questions never get posted at all. The needinfo goes to the bug's
creatorfrom the pre-flight lookup, not to anyone the model names, and only the question bypasses the hold: the diagnosis still waits for review belowhigh.Fixes #7181.