Repository navigation
Fix Matomo page view tracking (MatomoRouterModule.forRoot()) - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No page views reach Matomo.
src/main.tsimportsMatomoRouterModulebare instead ofMatomoRouterModule.forRoot(). Since ngx-matomo-client 7.0, the bare module only sets the "router tracking enabled" flag, and that flag turns off the initial-load page view (trackAppInitialLoad: !inject(MATOMO_ROUTER_ENABLED)). TheMatomoRouterservice and theENVIRONMENT_INITIALIZERthat subscribe toNavigationEndare registered only byforRoot(). So nothing callstrackPageView, and Matomo receives only outlink clicks and custom events.In 6.x the bare import worked, because the module constructor called
MatomoRouter.initialize()(MatomoRouterwasprovidedIn: 'root'). The 7.0 upgrade dropped that constructor.Fix
MatomoRouterModule→MatomoRouterModule.forRoot().Verification
npm ci && ng buildpasses.trackerUrlpointed at a local stub Matomo, and loaded it in headless Chrome. Before: no tracking requests. After: one page view,idsite=18,url=…/home. The other repos got the same one-line change and a build only.