Repository navigation
feat(theme): Add Modx PrimeVue 4 manager preset - #19
Ibochkarev wants to merge 3 commits into
Conversation
Ship a Nora-based Modx theme aligned with MODX Revolution 3 manager tokens (splash navy, 3px radius, 13px body). Export Modx helpers from the primevue bundle, add vuetools/theme Import Map aliases, demo showcase, docs, and bump to 1.1.3-pl.
Cache-bust vendor/composable URLs with filemtime so rebuilt primevue.min.js is not stuck behind HTTP cache. Tighten tabs, buttons, InputNumber, Panel/Card, and add InputGroup/ToggleButton tokens after MiniShop3 checks. Document barrel-only primevue imports so extras do not ship a second Theme instance.
Paginator nav uses hairline borders and splash selection instead of a primary fill. Active tab label uses splash primary; drop nested window-strip accent patterns from page-level Tabs.
|
@ Закрываю — темизацию делаем централизованной внутри VueToolsPR ценен (пресет Почему централизованно (в VueTools)Пресеты лежат в бандле VueTools; какой применить — решается в рантайме по значению, отданному с сервера. Тогда переключение темы не требует пересборки потребителей: флип настройки → сервер отдаёт другое значение → резолвер выбирает другой пресет → перекрашивается вся экосистема. Целевой механизм (сторона VueTools)
Тонкий контракт потребителяimport { PrimeVue } from primevue
import { getActiveTheme } from @vuetools/useTheme
app.use(PrimeVue, getActiveTheme()) // тему диктует VueToolsЧто переиспользуем из этого PRПресет Default Refs: MiniShop3 #640 (потребитель, тоже переработается под |
Add a PrimeVue 4 preset that follows the MODX Revolution 3 manager look.
Manager extras still defaulted to Aura (or a thin Nora skin). This adds token-based
Modxon Nora: splash#234368, 3px radius, 13px body, dense forms, tables, tabs, dialogs, and paginator. Dark mode is only insemantic.colorScheme.darkfor showcase apps.ModxManagerThemesetsdarkModeSelector: 'none'so Vue widgets stay light when ExtJS does.Forking Aura or dumping global
.p-*CSS would fight every PrimeVue update. Nora already has the dense rectangular baseline, so most of the work is tokens. A few CSS hooks remain where PrimeVue has no token (13px base font, tab strip overlap, paginator hairline borders).What ships:
Modx,ModxManagerTheme,ModxThemefrom the existingprimevue.min.jsbundlevuetoolsandvuetools/theme(same file)?v=from filemtime so rebuilt vendor/composables are not stuck in HTTP cachenpm run demoimport { … } from 'primevue'(subpaths likeprimevue/buttoncreate a second Theme instance)Checked against MiniShop3 in the manager: tabs (white active + splash label on
#F1F1F1), paginator (hairline borders, splash selection, no primary fill), buttons, InputNumber, Panel/Card, InputGroup, ToggleButton.In the manager, Save is
severity="success"; toolbar chrome isseverity="secondary". Aura remains for extras that already use it.Review focus: green Save contrast on white, DataTable density with Tag cells, and whether Aura consumers need more than the README note to switch.