Repository navigation
fix(customer): unify address hash generation between manager and storefront (#876) - #966
Open
Ibochkarev wants to merge 1 commit into
Open
Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
…efront (modx-pro#876) - Manager controller now uses same 4 fields (city, street, building, room) as CustomerAddressManager::generateHash() for hash calculation - update() merges existing address data with incoming data before hash recalculation to prevent hash corruption on partial updates - Fixes duplicate address creation when manager and storefront use different hash algorithms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Унифицирована генерация hash адресов покупателя между менеджерским API и витриной.
CustomerAddressesController::generateAddressHash()теперь использует те же 4 поля (city,street,building,room), что иCustomerAddressManager::generateHash()update()теперь объединяет данные текущей записи с входящими данными перед пересчётом hash, чтобы частичные обновления (например, толькоactive) не затирали hash пустыми значениямиТип изменений
Связанные Issues
Closes #876
Как это было протестировано?
Локальный CI-гейт (без полной установки MODX/MySQL), PHP lint из
.github/workflows/ci.yml:cd core/components/minishop3 composer install composer ci:phpcomposer ci:php/composer test, GitHub Actions CI)Конфигурация тестирования:
betabranchЧеклист
Дополнительные заметки
Существующие адреса с «неправильным» hash (рассчитанным по 7 полям) не будут автоматически пересчитаны. Для коррекции потребуется вручную обновить адрес через менеджерский API (хотя бы частичное обновление, например смена
active).